Re: [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only

2019-09-14 Thread Tony Lindgren
* Sebastian Reichel [190914 13:01]: > Hi, > > On Fri, Sep 13, 2019 at 03:09:19PM -0700, Tony Lindgren wrote: > > Also, we should not call prepare and unprepare except during init, and > > only call enable and disable during use. > > Why? Usually clk_(un)prepare() is the part saving most power, s

Re: [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only

2019-09-14 Thread Sebastian Reichel
Hi, On Fri, Sep 13, 2019 at 03:09:19PM -0700, Tony Lindgren wrote: > Also, we should not call prepare and unprepare except during init, and > only call enable and disable during use. Why? Usually clk_(un)prepare() is the part saving most power, so I would expect the runtime resume handlers to cal

[PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only

2019-09-13 Thread Tony Lindgren
When unloading omap3-rom-rng, we'll get the following: WARNING: CPU: 0 PID: 100 at drivers/clk/clk.c:948 clk_core_disable This is because the clock is already disabled by omap3_rom_rng_idle(). Also, we should not call prepare and unprepare except during init, and only call enable and disable dur