RE: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-10-17 Thread Pascal Van Leeuwen
...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks > > On Thu, Oct 17, 2019 at 3:26 PM Pascal Van Leeuwen > wrote: > > > > /* Register PCI driver */ > > > - pc

Re: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-10-17 Thread Arnd Bergmann
On Thu, Oct 17, 2019 at 3:26 PM Pascal Van Leeuwen wrote: > > /* Register PCI driver */ > > - pcireg_rc = pci_register_driver(&safexcel_pci_driver); > > -#endif > > + ret = pci_register_driver(&safexcel_pci_driver); > > > > -#if IS_ENABLED(CONFIG_OF) > > /* Register platform d

RE: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-10-17 Thread Pascal Van Leeuwen
Miller ; Bjorn Helgaas > Cc: Arnd Bergmann ; Pascal Van Leeuwen > ; Pascal van > Leeuwen ; Kelsey Skunberg ; > linux- > cry...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-...@vger.kernel.org > Subject: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks >

Re: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-10-10 Thread Herbert Xu
On Mon, Sep 30, 2019 at 02:14:35PM +0200, Arnd Bergmann wrote: > When both PCI and OF are disabled, no drivers are registered, and > we get some unused-function warnings: > > drivers/crypto/inside-secure/safexcel.c:1221:13: error: unused function > 'safexcel_unregister_algorithms' [-Werror,-Wunus

Re: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-09-30 Thread Bjorn Helgaas
On Mon, Sep 30, 2019 at 02:14:35PM +0200, Arnd Bergmann wrote: > When both PCI and OF are disabled, no drivers are registered, and > we get some unused-function warnings: > > drivers/crypto/inside-secure/safexcel.c:1221:13: error: unused function > 'safexcel_unregister_algorithms' [-Werror,-Wunus

[PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-09-30 Thread Arnd Bergmann
When both PCI and OF are disabled, no drivers are registered, and we get some unused-function warnings: drivers/crypto/inside-secure/safexcel.c:1221:13: error: unused function 'safexcel_unregister_algorithms' [-Werror,-Wunused-function] static void safexcel_unregister_algorithms(struct safexcel_c