Re: [PATCH 2/8] staging: ccree: use more readable func names

2017-11-08 Thread Gilad Ben-Yossef
Hi Dan, Thank you for reviewing the patch set. On Tue, Nov 7, 2017 at 12:30 PM, Dan Carpenter wrote: > > On Tue, Nov 07, 2017 at 09:39:58AM +, Gilad Ben-Yossef wrote: > > @@ -780,11 +766,10 @@ static inline int ssi_buffer_mgr_aead_chain_iv( > > unsigned int iv_size_to_authenc =

Re: [PATCH 2/8] staging: ccree: use more readable func names

2017-11-07 Thread Dan Carpenter
On Tue, Nov 07, 2017 at 09:39:58AM +, Gilad Ben-Yossef wrote: > @@ -780,11 +766,10 @@ static inline int ssi_buffer_mgr_aead_chain_iv( > unsigned int iv_size_to_authenc = crypto_aead_ivsize(tfm); > unsigned int iv_ofs = GCM_BLOCK_RFC4_IV_OFFSET; > /* Cha

[PATCH 2/8] staging: ccree: use more readable func names

2017-11-07 Thread Gilad Ben-Yossef
The driver was using a function naming scheme including common prefixes for driver global functions based on the code module they came from. The combination of long names with long common prefixes made the whole thing hard for a human to parse. Make the semantic change of switching to simple func