Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Ard Biesheuvel
On Fri, 20 Nov 2020 at 11:45, Herbert Xu wrote: > > On Fri, Nov 20, 2020 at 11:43:40AM +0100, Ard Biesheuvel wrote: > > > > That would be an option, but since we basically already have our own > > local 'EXPERT' option when it comes to crypto testing, I thought I'd > > use that instead. > > Well t

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Herbert Xu
On Fri, Nov 20, 2020 at 11:43:40AM +0100, Ard Biesheuvel wrote: > > That would be an option, but since we basically already have our own > local 'EXPERT' option when it comes to crypto testing, I thought I'd > use that instead. Well that creates a loop and changing the select into a dependency may

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Herbert Xu
On Fri, Nov 20, 2020 at 11:40:24AM +0100, Ard Biesheuvel wrote: > > Yeah, that would work, but enabling it as a builtin produces a lot of > bogus output if you fail to set the tcrypt.mode=xxx kernel command > line option, so it is really only intended for deliberate use. Perhaps replace it with a

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Ard Biesheuvel
On Fri, 20 Nov 2020 at 11:42, Herbert Xu wrote: > > On Fri, Nov 20, 2020 at 11:40:24AM +0100, Ard Biesheuvel wrote: > > > > Yeah, that would work, but enabling it as a builtin produces a lot of > > bogus output if you fail to set the tcrypt.mode=xxx kernel command > > line option, so it is really

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Ard Biesheuvel
On Fri, 20 Nov 2020 at 11:37, Herbert Xu wrote: > > On Fri, Nov 20, 2020 at 11:34:14AM +0100, Ard Biesheuvel wrote: > > On Fri, 20 Nov 2020 at 11:09, Herbert Xu > > wrote: > > > > > > On Fri, Nov 20, 2020 at 10:24:44AM +0100, Ard Biesheuvel wrote: > > > > > > > > OK, I'll apply this on top > > >

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Herbert Xu
On Fri, Nov 20, 2020 at 11:34:14AM +0100, Ard Biesheuvel wrote: > On Fri, 20 Nov 2020 at 11:09, Herbert Xu wrote: > > > > On Fri, Nov 20, 2020 at 10:24:44AM +0100, Ard Biesheuvel wrote: > > > > > > OK, I'll apply this on top > > > > > > diff --git a/crypto/Kconfig b/crypto/Kconfig > > > index 9ff2

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Ard Biesheuvel
On Fri, 20 Nov 2020 at 11:09, Herbert Xu wrote: > > On Fri, Nov 20, 2020 at 10:24:44AM +0100, Ard Biesheuvel wrote: > > > > OK, I'll apply this on top > > > > diff --git a/crypto/Kconfig b/crypto/Kconfig > > index 9ff2d687e334..959ee48f66a8 100644 > > --- a/crypto/Kconfig > > +++ b/crypto/Kconfig

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Herbert Xu
On Fri, Nov 20, 2020 at 10:24:44AM +0100, Ard Biesheuvel wrote: > > OK, I'll apply this on top > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 9ff2d687e334..959ee48f66a8 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -202,7 +202,7 @@ config CRYPTO_AUTHENC > config CRYPTO_TEST

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-20 Thread Ard Biesheuvel
On Fri, 20 Nov 2020 at 04:44, Herbert Xu wrote: > > On Mon, Nov 09, 2020 at 09:31:42AM +0100, Ard Biesheuvel wrote: > > When working on crypto algorithms, being able to run tcrypt quickly > > without booting an entire Linux installation can be very useful. For > > instance, QEMU/kvm can be used to

Re: [PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-19 Thread Herbert Xu
On Mon, Nov 09, 2020 at 09:31:42AM +0100, Ard Biesheuvel wrote: > When working on crypto algorithms, being able to run tcrypt quickly > without booting an entire Linux installation can be very useful. For > instance, QEMU/kvm can be used to boot a kernel from the command line, > and having tcrypt.k

[PATCH 2/3] crypto: tcrypt - permit tcrypt.ko to be builtin

2020-11-09 Thread Ard Biesheuvel
When working on crypto algorithms, being able to run tcrypt quickly without booting an entire Linux installation can be very useful. For instance, QEMU/kvm can be used to boot a kernel from the command line, and having tcrypt.ko builtin would allow tcrypt to be executed to run benchmarks, or to run