Re: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-10-10 Thread Herbert Xu
On Mon, Sep 30, 2019 at 02:14:34PM +0200, Arnd Bergmann wrote: > safexcel_aead_setkey() contains three large stack variables, totalling > slightly more than the 1024 byte warning limit: > > drivers/crypto/inside-secure/safexcel_cipher.c:303:12: error: stack frame > size of 1032 bytes in function

Re: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-10-01 Thread Arnd Bergmann
On Mon, Sep 30, 2019 at 11:09 PM Pascal Van Leeuwen wrote: > > Subject: Re: [PATCH 2/3] crypto: inside-secure - Reduce stack usage > > > > On Mon, Sep 30, 2019 at 9:04 PM Pascal Van Leeuwen > > wrote: > > > > > > Alternatively, it should be possible

RE: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-09-30 Thread Pascal Van Leeuwen
cry...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH 2/3] crypto: inside-secure - Reduce stack usage > > On Mon, Sep 30, 2019 at 9:04 PM Pascal Van Leeuwen > wrote: > > > > Alternatively, it should be possible to shrink these allocations > > > as the ex

Re: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-09-30 Thread Arnd Bergmann
On Mon, Sep 30, 2019 at 9:04 PM Pascal Van Leeuwen wrote: > > Alternatively, it should be possible to shrink these allocations > > as the extra buffers appear to be largely unnecessary, but doing > > this would be a much more invasive change. > > > Actually, for HMAC-SHA512 you DO need all that b

RE: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-09-30 Thread Pascal Van Leeuwen
-crypto@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: [PATCH 2/3] crypto: inside-secure - Reduce stack usage > > safexcel_aead_setkey() contains three large stack variables, totalling > slightly more than the 1024 byte warning limit: > > drivers/crypto/insi

[PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-09-30 Thread Arnd Bergmann
safexcel_aead_setkey() contains three large stack variables, totalling slightly more than the 1024 byte warning limit: drivers/crypto/inside-secure/safexcel_cipher.c:303:12: error: stack frame size of 1032 bytes in function 'safexcel_aead_setkey' [-Werror,-Wframe-larger-than=] The function alrea