Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-10-04 Thread Herbert Xu
On Thu, Sep 19, 2019 at 04:09:06PM +0200, Arnd Bergmann wrote: > To avoid missing arm64 specific warnings that get introduced > in this driver, allow compile-testing on all 64-bit architectures. > > The only actual arm64 specific code in this driver is an open- > coded 128 bit MMIO write. On non-a

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-10-02 Thread John Garry
On 21/09/2019 11:26, Zhou Wang wrote: On 2019/9/20 22:16, John Garry wrote: On 20/09/2019 14:36, Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: + if (!IS_ENABLED(CONFIG_ARM64)) { + memcpy_toio(fu

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-21 Thread Zhou Wang
On 2019/9/20 22:16, John Garry wrote: > On 20/09/2019 14:36, Arnd Bergmann wrote: >> On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote: >>> >>> On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: >>> > + if (!IS_ENABLED(CONFIG_ARM64)) { > + memcpy_toio(fun_base, src, 16);

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-20 Thread John Garry
On 20/09/2019 14:36, Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: + if (!IS_ENABLED(CONFIG_ARM64)) { + memcpy_toio(fun_base, src, 16); + wmb(); + return; + } + a

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-20 Thread Arnd Bergmann
On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote: > > On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: > > > > + if (!IS_ENABLED(CONFIG_ARM64)) { > > > + memcpy_toio(fun_base, src, 16); > > > + wmb(); > > > + return; > > > + } > > > + > > > a

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-20 Thread Arnd Bergmann
On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: > > + if (!IS_ENABLED(CONFIG_ARM64)) { > > + memcpy_toio(fun_base, src, 16); > > + wmb(); > > + return; > > + } > > + > > asm volatile("ldp %0, %1, %3\n" > >"stp %0, %1, %2\n"

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-20 Thread John Garry
On 19/09/2019 15:09, Arnd Bergmann wrote: To avoid missing arm64 specific warnings that get introduced in this driver, allow compile-testing on all 64-bit architectures. The only actual arm64 specific code in this driver is an open- coded 128 bit MMIO write. On non-arm64 the same can be done usi

[PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-19 Thread Arnd Bergmann
To avoid missing arm64 specific warnings that get introduced in this driver, allow compile-testing on all 64-bit architectures. The only actual arm64 specific code in this driver is an open- coded 128 bit MMIO write. On non-arm64 the same can be done using memcpy_toio. What I also noticed is that