Re: [PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption

2012-03-21 Thread Benjamin Herrenschmidt
On Wed, 2012-03-21 at 20:39 -0700, Greg KH wrote: > On Thu, Mar 22, 2012 at 01:57:30PM +1100, Benjamin Herrenschmidt wrote: > > +int __vio_register_driver(struct vio_driver *viodrv, struct module *owner, > > + const char *mod_name) > > { > > viodrv->driver.bus = &vio_bus_type

Re: [PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption

2012-03-21 Thread Greg KH
On Thu, Mar 22, 2012 at 01:57:30PM +1100, Benjamin Herrenschmidt wrote: > +int __vio_register_driver(struct vio_driver *viodrv, struct module *owner, > + const char *mod_name) > { > viodrv->driver.bus = &vio_bus_type; > + viodrv->driver.name = viodrv->name; > + vi

Re: [PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption

2012-03-21 Thread Benjamin Herrenschmidt
On Thu, 2012-03-22 at 12:50 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2012-03-21 at 15:15 -0700, Greg KH wrote: > > > > Really? vio drivers are supposed to look like this with the .name and > > .owner field manually being set in the static initialization of the > > driver? That's sad, and s

Re: [PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption

2012-03-21 Thread Benjamin Herrenschmidt
On Wed, 2012-03-21 at 15:15 -0700, Greg KH wrote: > > Really? vio drivers are supposed to look like this with the .name and > .owner field manually being set in the static initialization of the > driver? That's sad, and should be fixed, the vio core should do this > type of thing for you. Yeah

Re: [PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption

2012-03-21 Thread Greg KH
On Wed, Mar 21, 2012 at 04:41:08PM -0500, Kent Yoder wrote: > +static int nx_register_algs(void) > +{ > + int rc = -1; > + > + if (nx_driver.of.flags != NX_OF_FLAG_MASK_READY) > + goto out; > + > + memset(&nx_driver.stats, 0, sizeof(struct nx_stats)); > + > + rc = nx_sys

[PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption

2012-03-21 Thread Kent Yoder
These routines add the base device driver code supporting the Power7+ in-Nest encryption accelerator (nx) device. Signed-off-by: Kent Yoder --- arch/powerpc/crypto/nx/nx.c| 710 arch/powerpc/crypto/nx/nx.h| 190 ++ arch/powerpc/crypt