RE:(2) [PATCH 1/4] zstd: pass pointer rathen than structure to functions

2019-06-04 Thread Vaneet Narang
Hi Andrew,   >But struct ZSTD_CCtx_s.params is still a copied structure.  Could we >make it `const ZSTD_parameters *params'?  Probably not, due to lifetime >issues? ZSTD maintains its own ctxt. Yes we can avoid storing pointers of other modules because of lifetime issues. We should keep ZSTD_CCtx_

Re: [PATCH 1/4] zstd: pass pointer rathen than structure to functions

2019-06-03 Thread Andrew Morton
On Mon, 3 Jun 2019 14:32:03 +0530 Maninder Singh wrote: > currently params structure is passed in all functions, which increases > stack usage in all the function and lead to stack overflow on target like > ARM with kernel stack size of 8 KB so better to pass pointer. > > Checked for ARM: > >

[PATCH 1/4] zstd: pass pointer rathen than structure to functions

2019-06-03 Thread Maninder Singh
currently params structure is passed in all functions, which increases stack usage in all the function and lead to stack overflow on target like ARM with kernel stack size of 8 KB so better to pass pointer. Checked for ARM: Original Patched Call FLow