Re: [PATCH 1/4] crypto: algif_skcipher - Require setkey before accept(2)

2016-02-28 Thread Milan Broz
On 02/27/2016 10:40 PM, Sasha Levin wrote: > On 02/26/2016 06:44 AM, Milan Broz wrote: >> From: Herbert Xu >> >> commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. >> >> Some cipher implementations will crash if you try to use them >> without calling setkey first. This patch ad

Re: [PATCH 1/4] crypto: algif_skcipher - Require setkey before accept(2)

2016-02-27 Thread Sasha Levin
On 02/26/2016 06:44 AM, Milan Broz wrote: > From: Herbert Xu > > commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. > > Some cipher implementations will crash if you try to use them > without calling setkey first. This patch adds a check so that > the accept(2) call will

Re: [PATCH 1/4] crypto: algif_skcipher - Require setkey before accept(2)

2016-02-27 Thread Herbert Xu
On Fri, Feb 26, 2016 at 12:44:08PM +0100, Milan Broz wrote: > From: Herbert Xu > > commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. > > Some cipher implementations will crash if you try to use them > without calling setkey first. This patch adds a check so that > the ac

[PATCH 1/4] crypto: algif_skcipher - Require setkey before accept(2)

2016-02-26 Thread Milan Broz
From: Herbert Xu commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. Some cipher implementations will crash if you try to use them without calling setkey first. This patch adds a check so that the accept(2) call will fail with -ENOKEY if setkey hasn't been done on the