Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
On Tue, May 13, 2008 at 01:27:27PM -0700, Loc Ho wrote: > Hi, > > Patch 1/3 attached. I still can't get the line wrap problem solved. > Therefore it is attached instead inline. All applied. Thanks a lot! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTE

Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
On Wed, May 14, 2008 at 08:40:39PM +0800, Herbert Xu wrote: > > All ahash algorithms should provide a setkey function just like hash. > Digest algorithms should never come down this way. When we convert > digest algorithms over to ahash we should add setkey functions. Oh and for the vast majorit

Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
On Tue, May 13, 2008 at 01:27:27PM -0700, Loc Ho wrote: > > Please note: > 1. ahash_request has an extra variable 'void *info' for future uses with > KASUMI That's fine. We can change this structure at will. > 2. Any particular reason for removing ahash_nosetkey from function > crypto_init_ahas

[PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-13 Thread Loc Ho
Hi, Patch 1/3 attached. I still can't get the line wrap problem solved. Therefore it is attached instead inline. Please note: 1. ahash_request has an extra variable 'void *info' for future uses with KASUMI 2. Any particular reason for removing ahash_nosetkey from function crypto_init_ahash_ops -