Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

2014-11-23 Thread Julia Lawall
On Wed, 19 Nov 2014, Konstantin Khlebnikov wrote: > On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall wrote: > >> +// Comments: There are false positives in crypto/ where they are > >> actually freed. > > > > I didn't really understand this comment. I ran the semantic patch and got > > around 10

Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

2014-11-19 Thread Konstantin Khlebnikov
On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall wrote: >> +// Comments: There are false positives in crypto/ where they are >> actually freed. > > I didn't really understand this comment. I ran the semantic patch and got > around 10 results, but it wasn't clear to me how to see which were false >

Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

2014-11-19 Thread Julia Lawall
> +// Comments: There are false positives in crypto/ where they are > actually freed. I didn't really understand this comment. I ran the semantic patch and got around 10 results, but it wasn't clear to me how to see which were false positives. I would suggest to extend the rule a little bit to i

[PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

2014-11-18 Thread Konstantin Khlebnikov
Structures allocated by crypto_alloc_* must be freed using crypto_free_*. Signed-off-by: Konstantin Khlebnikov --- scripts/coccinelle/free/crypto_free.cocci | 64 + 1 file changed, 64 insertions(+) create mode 100644 scripts/coccinelle/free/crypto_free.cocci diff