Re: [PATCH 1/2] crypto: arm/ghash-ce - add missing async import/export

2016-09-05 Thread Herbert Xu
On Thu, Sep 01, 2016 at 04:14:22PM +0100, Ard Biesheuvel wrote: > > The culprit appears to be that the .cra_name of the internal shash is > "ghash", (and not "__ghash" like in the x86 case) which causes the > test code to run the test on not only the public ahash, but also on > the internal cryptd(

Re: [PATCH 1/2] crypto: arm/ghash-ce - add missing async import/export

2016-09-01 Thread Ard Biesheuvel
On 1 September 2016 at 14:19, Ard Biesheuvel wrote: > On 31 August 2016 at 15:41, Herbert Xu wrote: >> On Mon, Aug 29, 2016 at 12:19:53PM +0100, Ard Biesheuvel wrote: >>> Since commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero"), >>> all ahash drivers are required to implement im

Re: [PATCH 1/2] crypto: arm/ghash-ce - add missing async import/export

2016-09-01 Thread Ard Biesheuvel
On 31 August 2016 at 15:41, Herbert Xu wrote: > On Mon, Aug 29, 2016 at 12:19:53PM +0100, Ard Biesheuvel wrote: >> Since commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero"), >> all ahash drivers are required to implement import()/export(), and must have >> a non-zero statesize. Fi

Re: [PATCH 1/2] crypto: arm/ghash-ce - add missing async import/export

2016-08-31 Thread Herbert Xu
On Mon, Aug 29, 2016 at 12:19:53PM +0100, Ard Biesheuvel wrote: > Since commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero"), > all ahash drivers are required to implement import()/export(), and must have > a non-zero statesize. Fix this for the ARM Crypto Extensions GHASH > impleme

[PATCH 1/2] crypto: arm/ghash-ce - add missing async import/export

2016-08-29 Thread Ard Biesheuvel
Since commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero"), all ahash drivers are required to implement import()/export(), and must have a non-zero statesize. Fix this for the ARM Crypto Extensions GHASH implementation. Fixes: 8996eafdcbad ("crypto: ahash - ensure statesize is non-