Re: [PATCH 1/2] Fix static checker warning

2018-09-20 Thread Herbert Xu
On Thu, Sep 20, 2018 at 03:43:48PM +, Natarajan, Janakarajan wrote: > On 9/19/2018 8:57 AM, Dan Carpenter wrote: > > Sounds reasonable. The subject needs a subsystem prefix and it might > > be better to make it more specific. Like so: > > > > [PATCH 1/2] crypto: ccp - potential uninitialized

Re: [PATCH 1/2] Fix static checker warning

2018-09-20 Thread Natarajan, Janakarajan
On 9/19/2018 8:57 AM, Dan Carpenter wrote: > Sounds reasonable. The subject needs a subsystem prefix and it might > be better to make it more specific. Like so: > > [PATCH 1/2] crypto: ccp - potential uninitialized variable I'll put out a v2 with the subjects fixed. Thanks. > > I don't know if

Re: [PATCH 1/2] Fix static checker warning

2018-09-19 Thread Dan Carpenter
Sounds reasonable. The subject needs a subsystem prefix and it might be better to make it more specific. Like so: [PATCH 1/2] crypto: ccp - potential uninitialized variable I don't know if Herbert fixes those things up himself normally? regards, dan carpenter

Re: [PATCH 1/2] Fix static checker warning

2018-09-19 Thread Gary R Hook
On 09/14/2018 05:32 PM, Janakarajan Natarajan wrote: > Under certain configuration SEV functions can be defined as no-op. > In such a case error can be uninitialized. > > Initialize the variable to 0. > > Cc: Dan Carpenter > Reported-by: Dan Carpenter > Signed-off-by: Janakarajan Natarajan Ac

[PATCH 1/2] Fix static checker warning

2018-09-14 Thread Janakarajan Natarajan
Under certain configuration SEV functions can be defined as no-op. In such a case error can be uninitialized. Initialize the variable to 0. Cc: Dan Carpenter Reported-by: Dan Carpenter Signed-off-by: Janakarajan Natarajan --- drivers/crypto/ccp/psp-dev.c | 2 +- 1 file changed, 1 insertion(+)