Re: [PATCH 1/2] Crypto/chcr: Avoid some code duplication

2020-07-16 Thread Herbert Xu
On Sun, Jul 12, 2020 at 11:14:04PM +0200, Christophe JAILLET wrote: > The error handling path of 'chcr_authenc_setkey()' is the same as this > error handling code. > > So just 'goto out' as done everywhere in the function to simplify the code. > > Signed-off-by: Christophe JAILLET > --- > drive

Re: [PATCH 1/2] Crypto/chcr: Avoid some code duplication

2020-07-13 Thread Markus Elfring
> The error handling path of 'chcr_authenc_setkey()' is the same as this > error handling code. I find this change description improvable. > So just 'goto out' as done everywhere in the function to simplify the code. I propose to adjust jump targets a bit more for better exception handling in t

[PATCH 1/2] Crypto/chcr: Avoid some code duplication

2020-07-12 Thread Christophe JAILLET
The error handling path of 'chcr_authenc_setkey()' is the same as this error handling code. So just 'goto out' as done everywhere in the function to simplify the code. Signed-off-by: Christophe JAILLET --- drivers/crypto/chelsio/chcr_algo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(