Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-06 Thread Lokesh Vutla
Hi, On Monday 06 July 2015 01:05 PM, Herbert Xu wrote: > On Thu, Jul 02, 2015 at 10:48:38AM +0530, Lokesh Vutla wrote: >> Now the driver supports gcm mode, add omap-aes-gcm >> algo info to omap-aes driver. >> >> Signed-off-by: Lokesh Vutla > > You're using the old AEAD interface. We are now movi

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-06 Thread Herbert Xu
On Thu, Jul 02, 2015 at 10:48:38AM +0530, Lokesh Vutla wrote: > Now the driver supports gcm mode, add omap-aes-gcm > algo info to omap-aes driver. > > Signed-off-by: Lokesh Vutla You're using the old AEAD interface. We are now moving to the new AEAD interface so I will not be accepting any new

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-02 Thread Stephan Mueller
Am Donnerstag, 2. Juli 2015, 15:24:58 schrieb Lokesh Vutla: Hi Lokesh, >>> +{ >>> + .cra_name = "gcm(aes)", >>> + .cra_driver_name= "gcm-aes-omap", >>> + .cra_priority = 100, >> >> Why did you choose the priority 100? The software implementations commonly >>

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:30 PM, Stephan Mueller wrote: > Am Donnerstag, 2. Juli 2015, 10:48:38 schrieb Lokesh Vutla: > > Hi Lokesh, > >> Now the driver supports gcm mode, add omap-aes-gcm >> algo info to omap-aes driver. >> >> Signed-off-by: Lokesh Vutla >> --- >> drivers/crypto/omap-aes.c |

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-02 Thread Stephan Mueller
Am Donnerstag, 2. Juli 2015, 10:48:38 schrieb Lokesh Vutla: Hi Lokesh, >Now the driver supports gcm mode, add omap-aes-gcm >algo info to omap-aes driver. > >Signed-off-by: Lokesh Vutla >--- > drivers/crypto/omap-aes.c | 22 ++ > 1 file changed, 22 insertions(+) > >diff --git

[PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-01 Thread Lokesh Vutla
Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index e5e9a19..11f3850 10