Re: [PATCH 03/17] fs: don't allow to complete sync iocbs through aio_complete

2015-04-14 Thread Al Viro
On Tue, Apr 14, 2015 at 11:37:01AM -0700, Tadeusz Struk wrote: > The only problem is it calls init_sync_kiocb(&iocb, NULL) on a different iocb. > The one that isn't even passed to skcipher_recvmsg() > skcipher_recvmsg() checks is_sync_kiocb(msg->msg_iocb). > I just want to make sure that after the

Re: [PATCH 03/17] fs: don't allow to complete sync iocbs through aio_complete

2015-04-14 Thread Tadeusz Struk
On 04/14/2015 11:26 AM, Al Viro wrote: >>> @@ -766,8 +765,7 @@ int sock_recvmsg(struct socket *sock, struct msghdr >>> *msg, >>> > > >>> > > init_sync_kiocb(&iocb, NULL); >>> > > ret = __sock_recvmsg(&iocb, sock, msg, size, flags); >>> > > - if (-EIOCBQUEUED == ret) >>> > >

Re: [PATCH 03/17] fs: don't allow to complete sync iocbs through aio_complete

2015-04-14 Thread Al Viro
On Tue, Apr 14, 2015 at 11:00:49AM -0700, Tadeusz Struk wrote: > On 04/11/2015 02:18 PM, Al Viro wrote: > > @@ -766,8 +765,7 @@ int sock_recvmsg(struct socket *sock, struct msghdr > > *msg, > > > > init_sync_kiocb(&iocb, NULL); > > ret = __sock_recvmsg(&iocb, sock, msg, size, flags); > >

Re: [PATCH 03/17] fs: don't allow to complete sync iocbs through aio_complete

2015-04-14 Thread Tadeusz Struk
On 04/11/2015 02:18 PM, Al Viro wrote: > @@ -766,8 +765,7 @@ int sock_recvmsg(struct socket *sock, struct msghdr *msg, > > init_sync_kiocb(&iocb, NULL); > ret = __sock_recvmsg(&iocb, sock, msg, size, flags); > - if (-EIOCBQUEUED == ret) > - ret = wait_on_sync_kiocb(&io