Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-14 Thread Nicholas A. Bellinger
On Sun, 2011-03-13 at 17:01 +0800, Herbert Xu wrote: > On Thu, Mar 10, 2011 at 02:05:17AM -0800, Nicholas A. Bellinger wrote: > > > > We are still expecting the libcrypto consumer (iscsi_target_mod.ko) to > > call the arch independent crypto_alloc_hash("crc32c", ...) in order to > > have libcrypto

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-13 Thread Herbert Xu
On Thu, Mar 10, 2011 at 02:05:17AM -0800, Nicholas A. Bellinger wrote: > > We are still expecting the libcrypto consumer (iscsi_target_mod.ko) to > call the arch independent crypto_alloc_hash("crc32c", ...) in order to > have libcrypto backend logic perform a request_module() upon > architecture de

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-10 Thread Nicholas A. Bellinger
On Thu, 2011-03-10 at 01:13 -0800, Nicholas A. Bellinger wrote: > On Thu, 2011-03-10 at 17:09 +0800, Herbert Xu wrote: > > On Thu, Mar 10, 2011 at 12:54:24AM -0800, Nicholas A. Bellinger wrote: > > > > > > OK, so you mean each struct crypto_alg should define something like a > > > 'cra_optimized_na

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-10 Thread Nicholas A. Bellinger
On Thu, 2011-03-10 at 17:09 +0800, Herbert Xu wrote: > On Thu, Mar 10, 2011 at 12:54:24AM -0800, Nicholas A. Bellinger wrote: > > > > OK, so you mean each struct crypto_alg should define something like a > > 'cra_optimized_name' for which request_module(alg->cra_optimized_name) > > is called somewh

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-10 Thread Herbert Xu
On Thu, Mar 10, 2011 at 12:54:24AM -0800, Nicholas A. Bellinger wrote: > > OK, so you mean each struct crypto_alg should define something like a > 'cra_optimized_name' for which request_module(alg->cra_optimized_name) > is called somewhere in libcrypto code..? No, what I mean is that whenever we l

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-10 Thread Nicholas A. Bellinger
On Thu, 2011-03-10 at 16:43 +0800, Herbert Xu wrote: > On Thu, Mar 10, 2011 at 12:21:10AM -0800, Nicholas A. Bellinger wrote: > > > > Nicholas Bellinger (2): > > crypto: Add struct crypto_alg->cra_check_optimized > > crypto/crc32c: Add crc32c_cra_check_optimized for crc32c_intel > > I think y

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-10 Thread Herbert Xu
On Thu, Mar 10, 2011 at 12:21:10AM -0800, Nicholas A. Bellinger wrote: > > Nicholas Bellinger (2): > crypto: Add struct crypto_alg->cra_check_optimized > crypto/crc32c: Add crc32c_cra_check_optimized for crc32c_intel I think you misunderstood my suggestion. The reason I asked for this to be

[PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-10 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi Herbert and Co, This series adds a struct crypto_alg->cra_check_optimized() that can be optionally used by crc32c.ko (and other algorithms) in order to make a request_module() call to load architecture dependent offload code for a libcrypto base algorithm. This pat