Re: [PATCH v5 1/2] lib/mpi: Add mpi sgl helpers

2015-10-08 Thread Herbert Xu
On Thu, Oct 08, 2015 at 06:31:52AM -0700, Tadeusz Struk wrote: > > The sgl has to be big enough to take the whole integer. > What would be the point to export only part of a number? You're not getting it. Just because the SGL is X bytes long it doesn't give you the right to write X bytes. The nu

Re: [PATCH v5 1/2] lib/mpi: Add mpi sgl helpers

2015-10-08 Thread Tadeusz Struk
On 10/08/2015 06:02 AM, Herbert Xu wrote: > On Thu, Oct 01, 2015 at 10:10:38PM -0700, Tadeusz Struk wrote: >> >> +/** >> + * mpi_write_to_sgl() - Funnction exports MPI to an sgl (msb first) >> + * >> + * This function works in the same way as the mpi_read_buffer, but it >> + * takes an sgl instead

Re: [PATCH v5 1/2] lib/mpi: Add mpi sgl helpers

2015-10-08 Thread Herbert Xu
On Thu, Oct 01, 2015 at 10:10:38PM -0700, Tadeusz Struk wrote: > > +/** > + * mpi_write_to_sgl() - Funnction exports MPI to an sgl (msb first) > + * > + * This function works in the same way as the mpi_read_buffer, but it > + * takes an sgl instead of u8 * buf. > + * > + * @a: a multi

[PATCH v5 1/2] lib/mpi: Add mpi sgl helpers

2015-10-01 Thread Tadeusz Struk
Add mpi_read_raw_from_sgl and mpi_write_to_sgl helpers. Signed-off-by: Tadeusz Struk --- include/linux/mpi.h |4 + lib/mpi/mpicoder.c | 191 +++ 2 files changed, 195 insertions(+) diff --git a/include/linux/mpi.h b/include/linux/mpi.h index