Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-03 Thread Herbert Xu
On Mon, Jun 02, 2008 at 12:17:30PM -0400, Neil Horman wrote: > > Signed-off-by: Neil Horman <[EMAIL PROTECTED]> Applied to cryptodev-2.6. Thanks again! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Adrian-Ken Rueegsegger
Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: >> On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: >>> On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: I was wondering why you created your own test vectors. Wouldn't standardized test vectors by NIST o

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Neil Horman
On Mon, Jun 02, 2008 at 10:19:50PM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Mon, Jun 02, 2008 at 10:48:48PM +1000, Herbert Xu wrote: > >> On Mon, Jun 02, 2008 at 08:45:42AM -0400, Neil Horman wrote: > >>> Copy that. I think I found the problem, anyway. The verdict is that

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Mon, Jun 02, 2008 at 10:48:48PM +1000, Herbert Xu wrote: >> On Mon, Jun 02, 2008 at 08:45:42AM -0400, Neil Horman wrote: >>> Copy that. I think I found the problem, anyway. The verdict is that >>> Adrian was >>> right, and I'm klutz. I mixed up the output vector from a s

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Neil Horman
On Mon, Jun 02, 2008 at 10:48:48PM +1000, Herbert Xu wrote: > On Mon, Jun 02, 2008 at 08:45:42AM -0400, Neil Horman wrote: > > > > Copy that. I think I found the problem, anyway. The verdict is that > > Adrian was > > right, and I'm klutz. I mixed up the output vector from a successful and a >

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Neil Horman
On Mon, Jun 02, 2008 at 06:32:10PM +1000, Herbert Xu wrote: > On Mon, Jun 02, 2008 at 12:43:46AM +0200, Adrian-Ken Rueegsegger wrote: > > > > I just did a clean build on a different machine with the current HEAD > > (ac3f925c2bb1b08a41713394d78098857d3f40a7) > > of the cryptodev-2.6-tree. The two

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Herbert Xu
On Mon, Jun 02, 2008 at 08:45:42AM -0400, Neil Horman wrote: > > Copy that. I think I found the problem, anyway. The verdict is that Adrian > was > right, and I'm klutz. I mixed up the output vector from a successful and a > failed test during development. I'll repost shortly. Sorry for the t

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-02 Thread Herbert Xu
On Mon, Jun 02, 2008 at 12:43:46AM +0200, Adrian-Ken Rueegsegger wrote: > > I just did a clean build on a different machine with the current HEAD > (ac3f925c2bb1b08a41713394d78098857d3f40a7) > of the cryptodev-2.6-tree. The two tests fail on that box too. :( I will see > if I can spot something s

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Mon, Jun 02, 2008 at 12:43:46AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sun, Jun 01, 2008 at 06:09:46PM +0200, Adrian-Ken Rueegsegger wrote: > >> Neil Horman wrote: > >>> On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: >

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sun, Jun 01, 2008 at 06:09:46PM +0200, Adrian-Ken Rueegsegger wrote: >> Neil Horman wrote: >>> On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: Neil Horman wrote: [snip] These tests both seem to fail on my machine. Did you verify that the tes

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Sun, Jun 01, 2008 at 06:09:46PM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: > >> Neil Horman wrote: > >>> On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: > Could you document the source of

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sun, Jun 01, 2008 at 03:44:23AM +0200, Adrian-Ken Rueegsegger wrote: >> Neil Horman wrote: >>> On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: > I was wondering why you created your o

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: >> Neil Horman wrote: >>> On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: Could you document the source of these vectors in the patch description please? >>> Sure, reposting >>> >>> Pa

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: > >> Could you document the source of these vectors in the patch > >> description please? > > > > Sure, reposting > > > > Patch to add check

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Sun, Jun 01, 2008 at 03:44:23AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: > >> On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: > >>> I was wondering why you created your own test vectors. Would

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-31 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: >> On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: >>> I was wondering why you created your own test vectors. Wouldn't >>> standardized test vectors by NIST or ANSI be preferable? >> If you coul

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-31 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: >> Could you document the source of these vectors in the patch >> description please? > > Sure, reposting > > Patch to add checking of DES3 test vectors using CBC mode. FIPS-140-2 > compliance mandates that any sup

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-31 Thread Neil Horman
On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: > On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: > > > > I was wondering why you created your own test vectors. Wouldn't > > standardized test vectors by NIST or ANSI be preferable? > > If you could post a patch

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-30 Thread Herbert Xu
On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: > > I was wondering why you created your own test vectors. Wouldn't standardized > test vectors by NIST or ANSI be preferable? If you could post a patch with those that would be very much appreciated. Thanks! -- Visit Opens

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-30 Thread Adrian-Ken Rüegsegger
Neil Horman wrote: > On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: >> Could you document the source of these vectors in the patch >> description please? > > Sure, reposting > > Patch to add checking of DES3 test vectors using CBC mode. FIPS-140-2 > compliance mandates that any sup

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-23 Thread Herbert Xu
On Fri, May 23, 2008 at 08:34:58PM -0400, Neil Horman wrote: > > Signed-off-by: Neil Horman <[EMAIL PROTECTED]> Patch applied. Thanks a lot Neil! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Ke

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-23 Thread Neil Horman
On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: > Could you document the source of these vectors in the patch > description please? Sure, reposting Patch to add checking of DES3 test vectors using CBC mode. FIPS-140-2 compliance mandates that any supported mode of operation must inc

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-23 Thread Herbert Xu
Hi Neil: On Fri, May 23, 2008 at 04:18:55PM -0400, Neil Horman wrote: > Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 > compliance mandates that any supported mode of oepration must include a self > test. This satisfies that requirement for cbc(des_ebe). Tested successf

[PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-23 Thread Neil Horman
Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 compliance mandates that any supported mode of oepration must include a self test. This satisfies that requirement for cbc(des_ebe). Tested successfully by me Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> tc

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-22 Thread Neil Horman
On Thu, May 22, 2008 at 08:03:00AM +0800, Herbert Xu wrote: > On Wed, May 21, 2008 at 04:09:38PM -0400, Neil Horman wrote: > > Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 > > compliance mandates that any supported mode of oepration must include a self > > test. This sat

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-21 Thread Herbert Xu
On Wed, May 21, 2008 at 04:09:38PM -0400, Neil Horman wrote: > Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 > compliance mandates that any supported mode of oepration must include a self > test. This satisfies that requirement for cbc(des_ebe). Tested successfully > by

[PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-21 Thread Neil Horman
Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 compliance mandates that any supported mode of oepration must include a self test. This satisfies that requirement for cbc(des_ebe). Tested successfully by me Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> tc