Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2021-01-04 Thread Eric Biggers
On Fri, Nov 20, 2020 at 10:52:54AM -0800, Eric Biggers wrote: > On Mon, Oct 26, 2020 at 09:33:54AM -0700, Eric Biggers wrote: > > On Tue, Oct 06, 2020 at 08:51:45PM -0700, Eric Biggers wrote: > > > On Fri, Sep 18, 2020 at 02:57:05PM -0700, Eric Biggers wrote: > > > > On Fri, Sep 18, 2020 at 04:42:0

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-11-20 Thread Eric Biggers
On Mon, Oct 26, 2020 at 09:33:54AM -0700, Eric Biggers wrote: > On Tue, Oct 06, 2020 at 08:51:45PM -0700, Eric Biggers wrote: > > On Fri, Sep 18, 2020 at 02:57:05PM -0700, Eric Biggers wrote: > > > On Fri, Sep 18, 2020 at 04:42:07PM -0400, Theodore Y. Ts'o wrote: > > > > Ted, any further feedback

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-10-26 Thread Eric Biggers
On Tue, Oct 06, 2020 at 08:51:45PM -0700, Eric Biggers wrote: > On Fri, Sep 18, 2020 at 02:57:05PM -0700, Eric Biggers wrote: > > On Fri, Sep 18, 2020 at 04:42:07PM -0400, Theodore Y. Ts'o wrote: > > Ted, any further feedback on this? Are you planning to apply this patch? > > - Eric Ping.

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-10-06 Thread Eric Biggers
On Fri, Sep 18, 2020 at 02:57:05PM -0700, Eric Biggers wrote: > On Fri, Sep 18, 2020 at 04:42:07PM -0400, Theodore Y. Ts'o wrote: Ted, any further feedback on this? Are you planning to apply this patch? - Eric

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-09-18 Thread Eric Biggers
On Fri, Sep 18, 2020 at 04:42:07PM -0400, Theodore Y. Ts'o wrote: > > We're currently not bothering to deal with Endian conversions with the counter Endianness conversion for the counter isn't needed because the implementation only treats it as words, not as bytes. (Exception: the counter does ge

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-09-18 Thread Theodore Y. Ts'o
On Tue, Sep 15, 2020 at 09:50:13PM -0700, Eric Biggers wrote: > From: Eric Biggers > > On big endian CPUs, the ChaCha20-based CRNG is using the wrong > endianness for the ChaCha20 constants. > > This doesn't matter cryptographically, but technically it means it's not > ChaCha20 anymore. Fix it

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-09-17 Thread Herbert Xu
Eric Biggers wrote: > From: Eric Biggers > > On big endian CPUs, the ChaCha20-based CRNG is using the wrong > endianness for the ChaCha20 constants. > > This doesn't matter cryptographically, but technically it means it's not > ChaCha20 anymore. Fix it to always use the standard constants. >

[PATCH] random: initialize ChaCha20 constants with correct endianness

2020-09-15 Thread Eric Biggers
From: Eric Biggers On big endian CPUs, the ChaCha20-based CRNG is using the wrong endianness for the ChaCha20 constants. This doesn't matter cryptographically, but technically it means it's not ChaCha20 anymore. Fix it to always use the standard constants. Cc: linux-crypto@vger.kernel.org Sign