Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-11-10 Thread Corentin Labbe
On Tue, Oct 25, 2016 at 03:26:48PM +0200, Maxime Ripard wrote: > On Tue, Oct 25, 2016 at 07:38:55AM +0200, LABBE Corentin wrote: > > On Mon, Oct 24, 2016 at 10:10:20PM +0200, Maxime Ripard wrote: > > > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > > > Since SID's content is co

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-28 Thread LABBE Corentin
On Tue, Oct 25, 2016 at 09:06:34AM +0200, Jean-Francois Moine wrote: > On Tue, 25 Oct 2016 07:38:55 +0200 > LABBE Corentin wrote: > > > > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > > > Since SID's content is constant over reboot, > > > > > > That's not true, at least not

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-26 Thread Maxime Ripard
On Tue, Oct 25, 2016 at 07:38:55AM +0200, LABBE Corentin wrote: > On Mon, Oct 24, 2016 at 10:10:20PM +0200, Maxime Ripard wrote: > > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > > Since SID's content is constant over reboot, > > > > That's not true, at least not across all t

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-25 Thread Jean-Francois Moine
On Tue, 25 Oct 2016 07:38:55 +0200 LABBE Corentin wrote: > > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > > Since SID's content is constant over reboot, > > > > That's not true, at least not across all the Allwinner SoCs, and > > especially not on the A10 and A20 that this

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-24 Thread LABBE Corentin
On Mon, Oct 24, 2016 at 10:10:20PM +0200, Maxime Ripard wrote: > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > Since SID's content is constant over reboot, > > That's not true, at least not across all the Allwinner SoCs, and > especially not on the A10 and A20 that this drive

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-24 Thread Maxime Ripard
On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > Since SID's content is constant over reboot, That's not true, at least not across all the Allwinner SoCs, and especially not on the A10 and A20 that this driver supports. > it must not be used as source of randomness. And I don't

[PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-22 Thread Corentin Labbe
Since SID's content is constant over reboot, it must not be used as source of randomness. This patch remove the use of SID content as source of randomness. Signed-off-by: Corentin Labbe --- drivers/nvmem/sunxi_sid.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drive