Re: [PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-08-01 Thread Ard Biesheuvel
On Thu, 1 Aug 2019 at 09:08, Valdis Klētnieks wrote: > > On Thu, 01 Aug 2019 09:04:11 +0300, Ard Biesheuvel said: > > > The fact that crypto_aegis128_have_simd() does get optimized away, but > > crypto_aegis128_update_simd() doesn't (which is only called directly > > and not via a function pointer

Re: [PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-07-31 Thread Valdis Klētnieks
On Thu, 01 Aug 2019 09:04:11 +0300, Ard Biesheuvel said: > The fact that crypto_aegis128_have_simd() does get optimized away, but > crypto_aegis128_update_simd() doesn't (which is only called directly > and not via a function pointer like the other two routines) makes me > suspicious that this is

Re: [PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-07-31 Thread Ard Biesheuvel
On Thu, 1 Aug 2019 at 08:47, Valdis Klētnieks wrote: > > On Thu, 01 Aug 2019 08:01:54 +0300, Ard Biesheuvel said: > > > > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] > > > undefined! > > > ERROR: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! > > > ERROR: "cryp

Re: [PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-07-31 Thread Valdis Klētnieks
On Thu, 01 Aug 2019 08:01:54 +0300, Ard Biesheuvel said: > > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined! > > ERROR: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! > > ERROR: "crypto_aegis128_encrypt_chunk_simd" [crypto/aegis128.ko] undefined! > > make

Re: [PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-07-31 Thread Ard Biesheuvel
(+ Arnd) On Thu, 1 Aug 2019 at 07:52, Valdis Klētnieks wrote: > > The recent NEON SIMD patches break the build if CONFIG_CRYPTO_AEGIS128_SIMD > isn't set: > > MODPOST 558 modules > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined! > ERROR: "crypto_aegis128_update_simd

[PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-07-31 Thread Valdis Klētnieks
The recent NEON SIMD patches break the build if CONFIG_CRYPTO_AEGIS128_SIMD isn't set: MODPOST 558 modules ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined! ERROR: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! ERROR: "crypto_aegis128_encrypt_chunk_simd"