Re: [PATCH] libcrc32c: keep intermediate crc state in cpu order

2007-11-08 Thread Benny Halevy
On Nov. 08, 2007, 20:41 +0200, Dave Jiang <[EMAIL PROTECTED]> wrote: > Resolved my issue with BE open-iscsi initiator and LE IET target. Thanks! Super! Thanks for testing! And many thanks to Tomo for identifying the byte-order problem in the crypto code. Benny > > Benny Halevy wrote: >> cryp

Re: [PATCH] libcrc32c: keep intermediate crc state in cpu order

2007-11-08 Thread Dave Jiang
Resolved my issue with BE open-iscsi initiator and LE IET target. Thanks! Benny Halevy wrote: > crypto/crc32.c:chksum_final() is computing the digest as > *(__le32 *)out = ~cpu_to_le32(mctx->crc); > so the low-level crc32c_le routines should just keep > the crc in cpu order, otherwise it is gettin

Re: [PATCH] libcrc32c: keep intermediate crc state in cpu order

2007-11-08 Thread Herbert Xu
On Thu, Nov 08, 2007 at 10:20:34AM +0200, Benny Halevy wrote: > crypto/crc32.c:chksum_final() is computing the digest as > *(__le32 *)out = ~cpu_to_le32(mctx->crc); > so the low-level crc32c_le routines should just keep > the crc in cpu order, otherwise it is getting swabbed > one too many times on

[PATCH] libcrc32c: keep intermediate crc state in cpu order

2007-11-08 Thread Benny Halevy
crypto/crc32.c:chksum_final() is computing the digest as *(__le32 *)out = ~cpu_to_le32(mctx->crc); so the low-level crc32c_le routines should just keep the crc in cpu order, otherwise it is getting swabbed one too many times on big-endian machines. Signed-off-by: Benny Halevy <[EMAIL PROTECTED]> -