Re: [PATCH] hwrng: reorder OMAP TRNG driver code

2013-08-21 Thread Herbert Xu
On Wed, Aug 21, 2013 at 10:51:16AM +0530, Lokesh Vutla wrote: > Hi Olof, > On Tuesday 20 August 2013 11:37 PM, Olof Johansson wrote: > > The newly added omap4 support in the driver was added without > > consideration for building older configs. When building omap1_defconfig, > > it resulted in: > >

Re: [PATCH] hwrng: reorder OMAP TRNG driver code

2013-08-20 Thread Lokesh Vutla
Hi Olof, On Tuesday 20 August 2013 11:37 PM, Olof Johansson wrote: > The newly added omap4 support in the driver was added without > consideration for building older configs. When building omap1_defconfig, > it resulted in: > > drivers/char/hw_random/omap-rng.c:190:12: warning: 'omap4_rng_init' de

[PATCH] hwrng: reorder OMAP TRNG driver code

2013-08-20 Thread Olof Johansson
The newly added omap4 support in the driver was added without consideration for building older configs. When building omap1_defconfig, it resulted in: drivers/char/hw_random/omap-rng.c:190:12: warning: 'omap4_rng_init' defined but not used [-Wunused-function] drivers/char/hw_random/omap-rng.c:215