Re: [PATCH] hwrng: bcm2835 - remove redundant null check

2021-02-09 Thread Florian Fainelli
On 2/8/21 10:25 PM, Tian Tao wrote: > clk_prepare_enable() and clk_disable_unprepare() will check > NULL clock parameter, so It is not necessary to add additional checks. > > Signed-off-by: Tian Tao I don't believe this is going to work unless you also change devm_clk_get() to devm_clk_get_optio

[PATCH] hwrng: bcm2835 - remove redundant null check

2021-02-08 Thread Tian Tao
clk_prepare_enable() and clk_disable_unprepare() will check NULL clock parameter, so It is not necessary to add additional checks. Signed-off-by: Tian Tao --- drivers/char/hw_random/bcm2835-rng.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/char/hw_rand