Re: [PATCH] fscrypt: remove selection of CONFIG_CRYPTO_SHA256

2019-06-27 Thread Eric Biggers
On Thu, Jun 20, 2019 at 11:15:05AM -0700, Eric Biggers wrote: > From: Eric Biggers > > fscrypt only uses SHA-256 for AES-128-CBC-ESSIV, which isn't the default > and is only recommended on platforms that have hardware accelerated > AES-CBC but not AES-XTS. There's no link-time dependency, since

Re: [PATCH] fscrypt: remove selection of CONFIG_CRYPTO_SHA256

2019-06-27 Thread Theodore Ts'o
On Thu, Jun 20, 2019 at 11:15:05AM -0700, Eric Biggers wrote: > From: Eric Biggers > > fscrypt only uses SHA-256 for AES-128-CBC-ESSIV, which isn't the default > and is only recommended on platforms that have hardware accelerated > AES-CBC but not AES-XTS. There's no link-time dependency, since

Re: [PATCH] fscrypt: remove selection of CONFIG_CRYPTO_SHA256

2019-06-20 Thread Ard Biesheuvel
On Thu, 20 Jun 2019 at 20:16, Eric Biggers wrote: > > From: Eric Biggers > > fscrypt only uses SHA-256 for AES-128-CBC-ESSIV, which isn't the default > and is only recommended on platforms that have hardware accelerated > AES-CBC but not AES-XTS. There's no link-time dependency, since SHA-256 >

[PATCH] fscrypt: remove selection of CONFIG_CRYPTO_SHA256

2019-06-20 Thread Eric Biggers
From: Eric Biggers fscrypt only uses SHA-256 for AES-128-CBC-ESSIV, which isn't the default and is only recommended on platforms that have hardware accelerated AES-CBC but not AES-XTS. There's no link-time dependency, since SHA-256 is requested via the crypto API on first use. To reduce bloat,