Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-10-29 Thread Ard Biesheuvel
On Wed, 23 Sep 2020 at 13:03, Ben Greear wrote: > > On 8/4/20 12:45 PM, Ben Greear wrote: > > On 8/4/20 6:08 AM, Ard Biesheuvel wrote: > >> On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: > >>> > >>> On 8/4/20 5:55 AM, Ard Biesheuvel wrote: > On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: >

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-09-23 Thread Ben Greear
On 8/4/20 12:45 PM, Ben Greear wrote: On 8/4/20 6:08 AM, Ard Biesheuvel wrote: On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mb

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ard Biesheuvel
On Tue, 4 Aug 2020 at 21:45, Ben Greear wrote: > > On 8/4/20 6:08 AM, Ard Biesheuvel wrote: > > On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: > >> > >> On 8/4/20 5:55 AM, Ard Biesheuvel wrote: > >>> On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: > > Hello, > > This helps a b

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ben Greear
On 8/4/20 6:08 AM, Ard Biesheuvel wrote: On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my pa

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ben Greear
On 8/4/20 6:08 AM, Ard Biesheuvel wrote: On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my pa

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ard Biesheuvel
On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: > > On 8/4/20 5:55 AM, Ard Biesheuvel wrote: > > On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: > >> > >> Hello, > >> > >> This helps a bit...now download sw-crypt performance is about 150Mbps, > >> but still not as good as with my patch on 5.4 kerne

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ben Greear
On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my patch on 5.4 kernel, and fpu is still high in perf top: 13.89% libc-2.29.so [.] __mem

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ard Biesheuvel
On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: > > Hello, > > This helps a bit...now download sw-crypt performance is about 150Mbps, > but still not as good as with my patch on 5.4 kernel, and fpu is still > high in perf top: > > 13.89% libc-2.29.so [.] __memset_sse2_unaligned_erms >

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-03 Thread Ben Greear
Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my patch on 5.4 kernel, and fpu is still high in perf top: 13.89% libc-2.29.so [.] __memset_sse2_unaligned_erms 6.62% [kernel] [k] kernel_fpu_begin 4.14% [kernel]

[PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-02 Thread Ard Biesheuvel
Ben reports that CCM using AES-NI instructions performs pathologically poorly, which is due to the overhead of preserving/restoring the SIMD state, which is repeated after every 16 bytes of input when executing the CBCMAC portion of the algorithm. So let's clone the arm64 implementation of cbcmac(