Re: [PATCH] crypto: testmgr - test the shash API

2019-06-05 Thread Herbert Xu
On Tue, May 28, 2019 at 09:40:55AM -0700, Eric Biggers wrote: > From: Eric Biggers > > For hash algorithms implemented using the "shash" algorithm type, test > both the ahash and shash APIs, not just the ahash API. > > Testing the ahash API already tests the shash API indirectly, which is > norm

Re: [PATCH] crypto: testmgr - test the shash API

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 18:42, Eric Biggers wrote: > > From: Eric Biggers > > For hash algorithms implemented using the "shash" algorithm type, test > both the ahash and shash APIs, not just the ahash API. > > Testing the ahash API already tests the shash API indirectly, which is > normally good e

[PATCH] crypto: testmgr - test the shash API

2019-05-28 Thread Eric Biggers
From: Eric Biggers For hash algorithms implemented using the "shash" algorithm type, test both the ahash and shash APIs, not just the ahash API. Testing the ahash API already tests the shash API indirectly, which is normally good enough. However, there have been corner cases where there have be