Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-16 Thread Stephen Warren
On 09/13/2013 05:39 PM, Herbert Xu wrote: > On Fri, Sep 13, 2013 at 10:12:36AM -0600, Stephen Warren wrote: >> >> I'm curious which kernel version it was merged for; it'd be nice to >> remove tegra_chip_uid() from the Tegra tree now since it's unused, but >> that obviously requires this patch in th

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Herbert Xu
On Fri, Sep 13, 2013 at 10:12:36AM -0600, Stephen Warren wrote: > > I'm curious which kernel version it was merged for; it'd be nice to > remove tegra_chip_uid() from the Tegra tree now since it's unused, but > that obviously requires this patch in the history. This is in cryptodev which will be p

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Stephen Warren
On 09/13/2013 06:23 AM, Herbert Xu wrote: > On Mon, Sep 09, 2013 at 10:02:04AM -0600, Stephen Warren wrote: >> On 09/09/2013 01:35 AM, Linus Walleij wrote: >>> The way I read the Tegra AES RNG is that it has a homebrew >>> algorithm for initializing the 128bit RNG using timespec and >>> the unique

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Herbert Xu
On Mon, Sep 09, 2013 at 10:02:04AM -0600, Stephen Warren wrote: > On 09/09/2013 01:35 AM, Linus Walleij wrote: > > The way I read the Tegra AES RNG is that it has a homebrew > > algorithm for initializing the 128bit RNG using timespec and > > the unique chip ID. This looks like reinventing the (squ

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-09 Thread Stephen Warren
On 09/09/2013 01:35 AM, Linus Walleij wrote: > The way I read the Tegra AES RNG is that it has a homebrew > algorithm for initializing the 128bit RNG using timespec and > the unique chip ID. This looks like reinventing the (square) > wheel, instead just grab 128bits from the kernel entropy pool > w

[PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-09 Thread Linus Walleij
The way I read the Tegra AES RNG is that it has a homebrew algorithm for initializing the 128bit RNG using timespec and the unique chip ID. This looks like reinventing the (square) wheel, instead just grab 128bits from the kernel entropy pool where the time and (after another patch) chip unique ID