Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-10-04 Thread Marcelo Cerri
Hi Michael, On Ubuntu, CRYPTO_MANAGER_DISABLE_TESTS is set by default. So I had to disable this config in order to make sha1-powerpc fail in the crypto API tests. However, even with tests disabled, any usage of sha1-powerpc should result in incorrect results. -- Regards, Marcelo On Tue, Oct 04,

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-10-03 Thread Michael Ellerman
Marcelo Cerri writes: > [ Unknown signature status ] > On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote: >> On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote: >> > Hi Herbert, >> > >> > Any thoughts on this one? >> >> Can this patch wait until the next merge window? On the

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-10-02 Thread Herbert Xu
On Fri, Sep 23, 2016 at 04:31:56PM -0300, Marcelo Cerri wrote: > The driver does not handle endianness properly when loading the input > data. > > Signed-off-by: Marcelo Cerri Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.ap

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-09-28 Thread Marcelo Cerri
On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote: > On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote: > > Hi Herbert, > > > > Any thoughts on this one? > > Can this patch wait until the next merge window? On the broken > platforms it should just fail the self-test, right?

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-09-28 Thread Herbert Xu
On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote: > Hi Herbert, > > Any thoughts on this one? Can this patch wait until the next merge window? On the broken platforms it should just fail the self-test, right? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herb

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-09-28 Thread Marcelo Cerri
Hi Herbert, Any thoughts on this one? -- Regards, Marcelo On Fri, Sep 23, 2016 at 04:31:56PM -0300, Marcelo Cerri wrote: > The driver does not handle endianness properly when loading the input > data. > > Signed-off-by: Marcelo Cerri > --- > arch/powerpc/crypto/sha1-powerpc-asm.S | 13 ++

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-09-26 Thread Paulo Flabiano Smorigo
Fri, Sep 23, 2016 at 04:31:56PM -0300, Marcelo Cerri wrote: > The driver does not handle endianness properly when loading the input > data. Indeed. I tested in both endianesses and it's working fine. Thanks! Herbert, can we go ahead with this fix? > > Signed-off-by: Marcelo Cerri > --- > arch

[PATCH] crypto: sha1-powerpc: little-endian support

2016-09-23 Thread Marcelo Cerri
The driver does not handle endianness properly when loading the input data. Signed-off-by: Marcelo Cerri --- arch/powerpc/crypto/sha1-powerpc-asm.S | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/crypto/sha1-powerpc-asm.S b/arch/powerpc/crypto/sha