Re: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser

2016-05-11 Thread Herbert Xu
On Wed, May 11, 2016 at 07:41:31AM +, Tudor-Dan Ambarus wrote: > > If I move the DMA primitives to the driver context, > I can't assure software coherency enforcement in rsa helper. > > If so, after the ANS.1 parsing, if a driver needs to enforce software > coherency, it will have to allocate

RE: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser

2016-05-11 Thread Tudor-Dan Ambarus
Hi Herbert, > On Fri, Apr 29, 2016 at 03:51:46PM +0300, Tudor Ambarus wrote: > > > > struct rsa_key { > > + u8 *n; > > + u8 *e; > > + u8 *d; > > + dma_addr_t dma_n; > > + dma_addr_t dma_e; > > + dma_addr_t dma_d; > > + size_t n_sz; > > + size_t e_sz; > > + bool coherent; > > +

RE: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser

2016-05-05 Thread Tudor-Dan Ambarus
c: linux-crypto@vger.kernel.org; Tudor-Dan Ambarus > Subject: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser > > Return the raw integer with no other processing. > The scope is to have only one ANS.1 parser for the RSA keys. > > Update the RSA software implementation so tha

Re: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser

2016-05-03 Thread Herbert Xu
On Fri, Apr 29, 2016 at 03:51:46PM +0300, Tudor Ambarus wrote: > > struct rsa_key { > + u8 *n; > + u8 *e; > + u8 *d; > + dma_addr_t dma_n; > + dma_addr_t dma_e; > + dma_addr_t dma_d; > + size_t n_sz; > + size_t e_sz; > + bool coherent; > + gfp_t flags; Plea

[PATCH] crypto: rsa - return raw integer for the ASN.1 parser

2016-04-29 Thread Tudor Ambarus
Return the raw integer with no other processing. The scope is to have only one ANS.1 parser for the RSA keys. Update the RSA software implementation so that it does the MPI conversion on top. Signed-off-by: Tudor Ambarus --- crypto/rsa.c | 122 ++- crypto/rs