Re: [PATCH] crypto: mediatek: don't return garbage err on successful return

2017-01-12 Thread Herbert Xu
On Tue, Jan 03, 2017 at 01:21:22PM +, Colin King wrote: > From: Colin Ian King > > In the case where keylen <= bs mtk_sha_setkey returns an uninitialized > return value in err. Fix this by returning 0 instead of err. > > Issue detected by static analysis with cppcheck. > > Signed-off-by: C

[PATCH] crypto: mediatek: don't return garbage err on successful return

2017-01-03 Thread Colin King
From: Colin Ian King In the case where keylen <= bs mtk_sha_setkey returns an uninitialized return value in err. Fix this by returning 0 instead of err. Issue detected by static analysis with cppcheck. Signed-off-by: Colin Ian King --- drivers/crypto/mediatek/mtk-sha.c | 2 +- 1 file changed