Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-08-25 Thread Herbert Xu
On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > For the special case when we have a null input string, we want > to initialize the entry len to 0 for the hash/ahash walk, so > cyrpto_hash_walk_last will return the correct result indicating > that we have completed the scatter list walk.

Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-08-12 Thread Herbert Xu
On Mon, Aug 11, 2014 at 01:32:00PM -0700, Tim Chen wrote: > > Thanks Herbert. I was out on vacation for a while. Wonder if > you are planning to pick up the multi-buffer SHA1 series for 3.17 > kernel? Sorry it's too late for that but I'm planning in on putting it into cryptodev as soon as rc1 is

Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-08-11 Thread Tim Chen
On Fri, 2014-08-01 at 22:18 +0800, Herbert Xu wrote: > On Wed, Jul 23, 2014 at 09:07:45AM -0700, Tim Chen wrote: > > On Wed, 2014-07-23 at 21:09 +0800, Herbert Xu wrote: > > > On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > > > > For the special case when we have a null input string, we

Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-08-01 Thread Herbert Xu
On Wed, Jul 23, 2014 at 09:07:45AM -0700, Tim Chen wrote: > On Wed, 2014-07-23 at 21:09 +0800, Herbert Xu wrote: > > On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > > > For the special case when we have a null input string, we want > > > to initialize the entry len to 0 for the hash/aha

Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-07-23 Thread Tim Chen
On Wed, 2014-07-23 at 21:09 +0800, Herbert Xu wrote: > On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > > For the special case when we have a null input string, we want > > to initialize the entry len to 0 for the hash/ahash walk, so > > cyrpto_hash_walk_last will return the correct resu

Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-07-23 Thread Herbert Xu
On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > For the special case when we have a null input string, we want > to initialize the entry len to 0 for the hash/ahash walk, so > cyrpto_hash_walk_last will return the correct result indicating > that we have completed the scatter list walk.

[PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

2014-07-10 Thread Tim Chen
For the special case when we have a null input string, we want to initialize the entry len to 0 for the hash/ahash walk, so cyrpto_hash_walk_last will return the correct result indicating that we have completed the scatter list walk. Otherwise we may keep walking the sg list and access bogus memor