Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro

2019-10-18 Thread Herbert Xu
On Tue, Oct 15, 2019 at 10:13:30PM +0200, Rikard Falkeborn wrote: > Arguments are supposed to be ordered high then low. > > Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator") > Signed-off-by: Rikard Falkeborn > --- > Spotted when trying to introduce compile time checking t

Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro

2019-10-15 Thread Xu Zaibo
Agree with you, thanks! Zaibo . On 2019/10/16 4:13, Rikard Falkeborn wrote: Arguments are supposed to be ordered high then low. Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator") Signed-off-by: Rikard Falkeborn --- Spotted when trying to introduce compile time checkin

[PATCH] crypto: hisilicon: Fix misuse of GENMASK macro

2019-10-15 Thread Rikard Falkeborn
Arguments are supposed to be ordered high then low. Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator") Signed-off-by: Rikard Falkeborn --- Spotted when trying to introduce compile time checking that the order of the arguments to GENMASK are correct [0]. I have only compile