Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-05 Thread yumeng
在 2021/4/2 18:22, Herbert Xu 写道: On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote: I think it is not a real bug, and soft fallback setkey can always catch the error. But our original intention was to make it don't go to 'xxx_set_pub_key' when the key is null, and it can return an error

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread Herbert Xu
On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote: > > I think it is not a real bug, and soft fallback setkey can always catch the > error. > But our original intention was to make it don't go to 'xxx_set_pub_key' > when the key is null, and it can return an error earlier. > But maybe it is no

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread yumeng
在 2021/4/2 15:12, Herbert Xu 写道: On Fri, Mar 26, 2021 at 02:13:32PM +0800, Meng Yu wrote: We should ensure key is not empty before we set key. Signed-off-by: Meng Yu --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/h

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread Herbert Xu
On Fri, Mar 26, 2021 at 02:13:32PM +0800, Meng Yu wrote: > We should ensure key is not empty before we set key. > > Signed-off-by: Meng Yu > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto

[PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-03-25 Thread Meng Yu
We should ensure key is not empty before we set key. Signed-off-by: Meng Yu --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c index 53068d2..7cf7d80