Re: [PATCH] crypto: clarify name of WEAK_KEY request flag

2019-01-25 Thread Herbert Xu
On Fri, Jan 18, 2019 at 10:48:00PM -0800, Eric Biggers wrote: > From: Eric Biggers > > CRYPTO_TFM_REQ_WEAK_KEY confuses newcomers to the crypto API because it > sounds like it is requesting a weak key. Actually, it is requesting > that weak keys be forbidden (for algorithms that have the notion

[PATCH] crypto: clarify name of WEAK_KEY request flag

2019-01-18 Thread Eric Biggers
From: Eric Biggers CRYPTO_TFM_REQ_WEAK_KEY confuses newcomers to the crypto API because it sounds like it is requesting a weak key. Actually, it is requesting that weak keys be forbidden (for algorithms that have the notion of "weak keys"; currently only DES and XTS do). Also it is only one let