Re: [PATCH] crypto: ccp: Remove forward declaration

2018-10-04 Thread Herbert Xu
On Mon, Sep 24, 2018 at 10:26:15AM -0700, Nathan Chancellor wrote: > Clang emits a warning about this construct: > > drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array > definition assumed to have one element > static const struct acpi_device_id sp_acpi_match[]; >

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Gary R Hook
On 09/24/2018 04:44 PM, Nick Desaulniers wrote: > On Mon, Sep 24, 2018 at 2:27 PM Gary R Hook wrote: >> >> On 09/24/2018 03:24 PM, Nick Desaulniers wrote: >>> On Mon, Sep 24, 2018 at 12:18 PM Gary R Hook wrote: On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > Clang emits a warning

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nathan Chancellor
On Mon, Sep 24, 2018 at 02:42:56PM -0700, Nick Desaulniers wrote: > On Mon, Sep 24, 2018 at 2:22 PM Gary R Hook wrote: > > > > On 09/24/2018 02:40 PM, Nathan Chancellor wrote: > > > On Mon, Sep 24, 2018 at 07:18:23PM +, Gary R Hook wrote: > > >> On 09/24/2018 12:26 PM, Nathan Chancellor wrote:

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nick Desaulniers
On Mon, Sep 24, 2018 at 2:27 PM Gary R Hook wrote: > > On 09/24/2018 03:24 PM, Nick Desaulniers wrote: > > On Mon, Sep 24, 2018 at 12:18 PM Gary R Hook wrote: > >> > >> On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > >>> Clang emits a warning about this construct: > >>> > >>> drivers/crypto/cc

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nick Desaulniers
On Mon, Sep 24, 2018 at 2:22 PM Gary R Hook wrote: > > On 09/24/2018 02:40 PM, Nathan Chancellor wrote: > > On Mon, Sep 24, 2018 at 07:18:23PM +, Gary R Hook wrote: > >> On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > >>> Clang emits a warning about this construct: > >>> > >>> drivers/crypt

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Gary R Hook
On 09/24/2018 03:24 PM, Nick Desaulniers wrote: > On Mon, Sep 24, 2018 at 12:18 PM Gary R Hook wrote: >> >> On 09/24/2018 12:26 PM, Nathan Chancellor wrote: >>> Clang emits a warning about this construct: >>> >>> drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array >>> definition assum

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Gary R Hook
On 09/24/2018 02:40 PM, Nathan Chancellor wrote: > On Mon, Sep 24, 2018 at 07:18:23PM +, Gary R Hook wrote: >> On 09/24/2018 12:26 PM, Nathan Chancellor wrote: >>> Clang emits a warning about this construct: >>> >>> drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array >>> definition

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nick Desaulniers
On Mon, Sep 24, 2018 at 12:18 PM Gary R Hook wrote: > > On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > > Clang emits a warning about this construct: > > > > drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array > > definition assumed to have one element > > static const struct acpi_

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nathan Chancellor
On Mon, Sep 24, 2018 at 07:18:23PM +, Gary R Hook wrote: > On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > > Clang emits a warning about this construct: > > > > drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array > > definition assumed to have one element > > static const struc

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Gary R Hook
On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > Clang emits a warning about this construct: > > drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array > definition assumed to have one element > static const struct acpi_device_id sp_acpi_match[]; > ^

[PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nathan Chancellor
Clang emits a warning about this construct: drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array definition assumed to have one element static const struct acpi_device_id sp_acpi_match[]; ^ 1 warning generated. Just remove the forward declarations an