Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Horia Geantă
On 6/18/2020 2:00 PM, Herbert Xu wrote: > On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia Geantă wrote: >> >> The proper fix would be updating the ahash_finup_no_ctx() function >> to return the specific error code: >> return ret; >> instead of returning -ENOMEM for all error cases. >> >> For e

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Herbert Xu
On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia Geantă wrote: > > The proper fix would be updating the ahash_finup_no_ctx() function > to return the specific error code: > return ret; > instead of returning -ENOMEM for all error cases. > > For example error code returned by dpaa2_caam_enqueu

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Horia Geantă
On 6/11/2020 6:39 PM, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned a value that is never read, the > error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning > ret with -ENOMEM is redundamt. > > Addresses-Coverity: ("Unused value") > Signed-off-by

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Herbert Xu
On Thu, Jun 18, 2020 at 01:40:55PM +0300, Horia Geantă wrote: > On 6/18/2020 10:58 AM, Herbert Xu wrote: > > On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The variable ret is being assigned a value that is never read, the > >> error exit path via l

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Horia Geantă
On 6/18/2020 10:58 AM, Herbert Xu wrote: > On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The variable ret is being assigned a value that is never read, the >> error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning >> ret with -ENOMEM is r

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Herbert Xu
On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned a value that is never read, the > error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning > ret with -ENOMEM is redundamt. > > Addresses-Coverity: ("Unused val

[PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-11 Thread Colin King
From: Colin Ian King The variable ret is being assigned a value that is never read, the error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning ret with -ENOMEM is redundamt. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/crypto/caam/caamalg_qi2.c