Re: [PATCH] crypto: arm/aes-ce: assign err return conditionally

2017-02-11 Thread Nicholas Mc Guire
On Sat, Feb 11, 2017 at 05:39:46PM +0800, Herbert Xu wrote: > On Wed, Feb 08, 2017 at 02:36:19PM +0100, Nicholas Mc Guire wrote: > > As the err value is not used unless there was an error it can be assigned > > conditionally here. > > > > Signed-off-by: Nicholas Mc Guire > > This patch just add

Re: [PATCH] crypto: arm/aes-ce: assign err return conditionally

2017-02-11 Thread Herbert Xu
On Wed, Feb 08, 2017 at 02:36:19PM +0100, Nicholas Mc Guire wrote: > As the err value is not used unless there was an error it can be assigned > conditionally here. > > Signed-off-by: Nicholas Mc Guire This patch just adds noise to the commit history. So I'm not going to apply it. -- Email: H

[PATCH] crypto: arm/aes-ce: assign err return conditionally

2017-02-08 Thread Nicholas Mc Guire
As the err value is not used unless there was an error it can be assigned conditionally here. Signed-off-by: Nicholas Mc Guire --- Not sure if this is really relevant and worth changing, effectively it is practically no change as gcc would move the err = PTR_ERR(simd); below unregister_simds: