Re: [PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-20 Thread NĂ­colas F . R . A . Prado
On Sat, May 18, 2024 at 03:03:51PM +0800, Herbert Xu wrote: > On Fri, May 17, 2024 at 09:31:15PM -0700, Eric Biggers wrote: > > > > This is "normal" behavior when the crypto API instantiates a template: > > > > 1. drbg.c asks for "hmac(sha512)" > > > > 2. The crypto API looks for a direct

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-18 Thread Herbert Xu
On Sat, May 18, 2024 at 06:07:39AM -0700, James Bottomley wrote: > > I have a curiosity question: if Eric is right and it's looking for an > optional hmac accelerator module, why don't I see this? The only real config > difference between what I tested and what Nicholas did is he's arm and I'm

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-18 Thread James Bottomley
On May 18, 2024 5:32:56 AM PDT, Herbert Xu wrote: >On Sat, May 18, 2024 at 02:04:18PM +0300, Jarkko Sakkinen wrote: >> >> Right does this mean for TPM driver that a crypto API invocation not >> having everthing needed loaded will block until this is not the case? > >All this does is disable module

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-18 Thread Jarkko Sakkinen
On Sat May 18, 2024 at 3:32 PM EEST, Herbert Xu wrote: > On Sat, May 18, 2024 at 02:04:18PM +0300, Jarkko Sakkinen wrote: > > > > Right does this mean for TPM driver that a crypto API invocation not > > having everthing needed loaded will block until this is not the case? > > All this does is disab

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-18 Thread Herbert Xu
On Sat, May 18, 2024 at 02:04:18PM +0300, Jarkko Sakkinen wrote: > > Right does this mean for TPM driver that a crypto API invocation not > having everthing needed loaded will block until this is not the case? All this does is disable module loading by the Crypto API (because there is no point and

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-18 Thread Jarkko Sakkinen
On Sat May 18, 2024 at 10:03 AM EEST, Herbert Xu wrote: > When the Crypto API is built into the kernel, it may be invoked > during system initialisation before modules can be loaded. Ensure > that it doesn't load modules if this is the case by checking > crypto_boot_test_finished(). > > Add a call

[PATCH] crypto: api - Do not load modules until algapi is ready

2024-05-18 Thread Herbert Xu
On Fri, May 17, 2024 at 09:31:15PM -0700, Eric Biggers wrote: > > This is "normal" behavior when the crypto API instantiates a template: > > 1. drbg.c asks for "hmac(sha512)" > > 2. The crypto API looks for a direct implementation of "hmac(sha512)". >This includes requesting a mod