Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-28 Thread Tadeusz Struk
On 01/28/2016 09:09 AM, Stephan Mueller wrote: > Am Donnerstag, 28. Januar 2016, 08:00:25 schrieb Tadeusz Struk: > > Hi Tadeusz, > >> Hi Stephan, >> >> On 01/27/2016 10:26 PM, Stephan Mueller wrote: + for (i = 0; i < areq->tsgls; i++) > + put_page(sg_page(sg + i)); >>> >>>

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-28 Thread Stephan Mueller
Am Donnerstag, 28. Januar 2016, 08:00:25 schrieb Tadeusz Struk: Hi Tadeusz, >Hi Stephan, > >On 01/27/2016 10:26 PM, Stephan Mueller wrote: >>> + for (i = 0; i < areq->tsgls; i++) >>> >>> > + put_page(sg_page(sg + i)); >> >> Shouldn't here be the same logic as in put_sgl? I.e. >> >>

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-28 Thread Tadeusz Struk
Hi Stephan, On 01/27/2016 10:26 PM, Stephan Mueller wrote: >> +for (i = 0; i < areq->tsgls; i++) >> > + put_page(sg_page(sg + i)); > Shouldn't here be the same logic as in put_sgl? I.e. > > for (i = 0; i < sgl->cur; i++) { > if (!sg_page(sg + i)) >

Re: [kbuild-all] [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-28 Thread Fengguang Wu
On Wed, Jan 27, 2016 at 02:41:36PM -0800, Tadeusz Struk wrote: > On 01/27/2016 02:29 PM, kbuild test robot wrote: > > Hi Tadeusz, > > > > [auto build test ERROR on cryptodev/master] > > [also build test ERROR on v4.5-rc1 next-20160127] > > [if your patch is applied to the wrong git tree, please dr

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread Stephan Mueller
Am Mittwoch, 27. Januar 2016, 14:10:31 schrieb Tadeusz Struk: Hi Tadeusz, > Following the async change for algif_skcipher > this patch adds similar async read to algif_aead. > > changes in v2: > - change internal data structures from fixed size arrays, limited to > RSGL_MAX_ENTRIES, to linked

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread Tadeusz Struk
On 01/27/2016 02:29 PM, kbuild test robot wrote: > Hi Tadeusz, > > [auto build test ERROR on cryptodev/master] > [also build test ERROR on v4.5-rc1 next-20160127] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://githu

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread kbuild test robot
Hi Tadeusz, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.5-rc1 next-20160127] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-af_alg-add-async-s

[PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread Tadeusz Struk
Following the async change for algif_skcipher this patch adds similar async read to algif_aead. changes in v2: - change internal data structures from fixed size arrays, limited to RSGL_MAX_ENTRIES, to linked list model with no artificial limitation. - use sock_kmalloc instead of kmalloc for memo

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-20 Thread Herbert Xu
On Wed, Jan 20, 2016 at 12:18:24PM -0800, Tadeusz Struk wrote: > > I tried sock_kmalloc and it will not work. The sysctl_optmem_max by > default is 20480 bytes. The aead ctx by itself takes more than half of > it (11832 bytes). A single async request takes 11408 bytes. > It means we need to use kma

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-20 Thread Tadeusz Struk
Hi Herbert, On 01/18/2016 04:34 PM, Herbert Xu wrote: >> My understanding is that the sock_kmalloc is mainly used for allocations >> > of the user provided data, because it keeps tracks of how much memory >> > is allocated by a socket, and makes sure that is will not exceed the >> > sysctl_optmem_