Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-20 Thread Herbert Xu
On Fri, Aug 19, 2011 at 08:15:16AM -0400, Josh Boyer wrote: > On Fri, Aug 19, 2011 at 04:12:08PM +0800, Herbert Xu wrote: > > On Fri, Aug 19, 2011 at 03:32:24PM +0800, Herbert Xu wrote: > > > > > > Meanwhile I'll make a patch that ensures cryptd is registered > > > before aesni. > > > > Please tr

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-19 Thread Josh Boyer
On Fri, Aug 19, 2011 at 04:12:08PM +0800, Herbert Xu wrote: > On Fri, Aug 19, 2011 at 03:32:24PM +0800, Herbert Xu wrote: > > > > Meanwhile I'll make a patch that ensures cryptd is registered > > before aesni. > > Please try this patch. Thanks! This worked great. I'm confused why adding ivsize

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-19 Thread Herbert Xu
On Fri, Aug 19, 2011 at 03:32:24PM +0800, Herbert Xu wrote: > > Meanwhile I'll make a patch that ensures cryptd is registered > before aesni. Please try this patch. Thanks! commit 9d4c522a113f6caa8b792ae829a25490fa87b1a2 Author: Herbert Xu Date: Fri Aug 19 16:11:23 2011 +0800 crypto: cr

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-19 Thread Herbert Xu
On Thu, Aug 18, 2011 at 10:15:17PM -0400, Josh Boyer wrote: > On Fri, Aug 19, 2011 at 08:02:29AM +0800, Herbert Xu wrote: > > On Thu, Aug 18, 2011 at 01:44:25PM -0400, Josh Boyer wrote: > > > > > > Any luck on this? If there's anything further I can try or if you need > > > some data from me, just

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-18 Thread Herbert Xu
On Thu, Aug 18, 2011 at 01:44:25PM -0400, Josh Boyer wrote: > > Any luck on this? If there's anything further I can try or if you need > some data from me, just let me know. Can you send me your .config file? Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-18 Thread Josh Boyer
On Tue, Aug 16, 2011 at 08:32:27PM +0800, Herbert Xu wrote: > On Mon, Aug 15, 2011 at 07:50:39AM -0400, Josh Boyer wrote: > > > > Well, yes, it does in this code: > > > > if (!((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) == > > CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize : > >

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-16 Thread Herbert Xu
On Mon, Aug 15, 2011 at 07:50:39AM -0400, Josh Boyer wrote: > > Well, yes, it does in this code: > > if (!((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) == > CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize : > alg->cra_ablkcipher.ivsize)) {

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-15 Thread Josh Boyer
On Mon, Aug 15, 2011 at 03:15:28PM +0800, Herbert Xu wrote: > On Thu, Aug 11, 2011 at 12:40:41PM -0400, Josh Boyer wrote: > > The ablkcipher structure in ablk_ecb_alg is lacking an ivsize setting. > > This causes the algorithm to fail it's self-test when it's registered > > with the error message:

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-15 Thread Herbert Xu
On Thu, Aug 11, 2011 at 12:40:41PM -0400, Josh Boyer wrote: > The ablkcipher structure in ablk_ecb_alg is lacking an ivsize setting. > This causes the algorithm to fail it's self-test when it's registered > with the error message: > > [0.806920] alg: skcipher: Failed to load transform for ecb-

[PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-11 Thread Josh Boyer
The ablkcipher structure in ablk_ecb_alg is lacking an ivsize setting. This causes the algorithm to fail it's self-test when it's registered with the error message: [0.806920] alg: skcipher: Failed to load transform for ecb-aes-aesni: -2 crypto_lookup_skcipher doesn't like a missing ivsize.