Re: [PATCH] crypto: Use ___cacheline_aligned for aes data

2019-04-07 Thread Herbert Xu
On Fri, Mar 29, 2019 at 05:46:29PM -0700, Andi Kleen wrote: > From: Andi Kleen > > cacheline_aligned is a special section. It cannot be const at the same > time because it's not read-only. It doesn't give any MMU protection. > > Mark it cacheline_aligned to not place it in a special section,

Re: [PATCH] crypto: Use ___cacheline_aligned for aes data

2019-03-30 Thread Yann Droneaud
Hi, Le vendredi 29 mars 2019 à 17:46 -0700, Andi Kleen a écrit : > > Mark it cacheline_aligned to not place it in a special section, > but just align it in .rodata > Small typo: commit title seems to suggests there's only 3 underscore ('___cacheline_aligned') instead of 4. Regards. -- Ya

Re: [PATCH] crypto: Use ___cacheline_aligned for aes data

2019-03-30 Thread Ard Biesheuvel
On Sat, 30 Mar 2019 at 01:46, Andi Kleen wrote: > > From: Andi Kleen > > cacheline_aligned is a special section. It cannot be const at the same > time because it's not read-only. It doesn't give any MMU protection. > > Mark it cacheline_aligned to not place it in a special section, > but just

[PATCH] crypto: Use ___cacheline_aligned for aes data

2019-03-29 Thread Andi Kleen
From: Andi Kleen cacheline_aligned is a special section. It cannot be const at the same time because it's not read-only. It doesn't give any MMU protection. Mark it cacheline_aligned to not place it in a special section, but just align it in .rodata Cc: herb...@gondor.apana.org.au Suggested