Re: [PATCH] crypto: Fix test in get_prng_bytes()

2009-10-27 Thread Herbert Xu
On Mon, Oct 12, 2009 at 10:29:08AM -0400, Neil Horman wrote: > > Acked-by: Neil Horman Patch applied to cryptodev. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pub

Re: [PATCH] crypto: Fix test in get_prng_bytes()

2009-10-12 Thread Neil Horman
On Mon, Oct 12, 2009 at 04:22:05PM +0200, Roel Kluin wrote: > Op 12-10-09 16:07, Herbert Xu schreef: > > On Mon, Oct 12, 2009 at 09:51:42AM -0400, Neil Horman wrote: > > . > >>> Or should this test be removed? > >>> > >>> diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > >>> index 3aa6e38..9

Re: [PATCH] crypto: Fix test in get_prng_bytes()

2009-10-12 Thread Neil Horman
On Mon, Oct 12, 2009 at 11:07:53PM +0900, Herbert Xu wrote: > On Mon, Oct 12, 2009 at 09:51:42AM -0400, Neil Horman wrote: > . > > > Or should this test be removed? > > > > > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > > > index 3aa6e38..9162456 100644 > > > --- a/crypto/ansi_cprng.

Re: [PATCH] crypto: Fix test in get_prng_bytes()

2009-10-12 Thread Roel Kluin
Op 12-10-09 16:07, Herbert Xu schreef: > On Mon, Oct 12, 2009 at 09:51:42AM -0400, Neil Horman wrote: > . >>> Or should this test be removed? >>> >>> diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c >>> index 3aa6e38..9162456 100644 >>> --- a/crypto/ansi_cprng.c >>> +++ b/crypto/ansi_cprng.c

Re: [PATCH] crypto: Fix test in get_prng_bytes()

2009-10-12 Thread Herbert Xu
On Mon, Oct 12, 2009 at 09:51:42AM -0400, Neil Horman wrote: . > > Or should this test be removed? > > > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > > index 3aa6e38..9162456 100644 > > --- a/crypto/ansi_cprng.c > > +++ b/crypto/ansi_cprng.c > > @@ -192,7 +192,7 @@ static int get_prn

Re: [PATCH] crypto: Fix test in get_prng_bytes()

2009-10-12 Thread Neil Horman
On Mon, Oct 12, 2009 at 03:09:09PM +0200, Roel Kluin wrote: > size_t nbytes cannot be less than 0. > > Signed-off-by: Roel Kluin > --- > Or should this test be removed? > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > index 3aa6e38..9162456 100644 > --- a/crypto/ansi_cprng.c > +++ b/

[PATCH] crypto: Fix test in get_prng_bytes()

2009-10-12 Thread Roel Kluin
size_t nbytes cannot be less than 0. Signed-off-by: Roel Kluin --- Or should this test be removed? diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c index 3aa6e38..9162456 100644 --- a/crypto/ansi_cprng.c +++ b/crypto/ansi_cprng.c @@ -192,7 +192,7 @@ static int get_prng_bytes(char *buf, siz