Re: [PATCH] crypto: AEAD: add check for presence of auth tag

2015-01-05 Thread Stephan Mueller
Am Montag, 5. Januar 2015, 21:55:40 schrieb Herbert Xu: Hi Herbert, > On Mon, Jan 05, 2015 at 11:53:38AM +0100, Stephan Mueller wrote: > > Could you please check: I am unable to find the function. > > It's in crypto/authenc.c. > > > Note, there is no size parameter provided in crypto_aead_decry

Re: [PATCH] crypto: AEAD: add check for presence of auth tag

2015-01-05 Thread Herbert Xu
On Mon, Jan 05, 2015 at 11:53:38AM +0100, Stephan Mueller wrote: > > Could you please check: I am unable to find the function. It's in crypto/authenc.c. > Note, there is no size parameter provided in crypto_aead_decrypt. To obtain > the size, I would need to walk the scatterlists, no? The crypt

Re: [PATCH] crypto: AEAD: add check for presence of auth tag

2015-01-05 Thread Stephan Mueller
Am Montag, 5. Januar 2015, 21:39:57 schrieb Herbert Xu: Hi Herbert, > On Mon, Jan 05, 2015 at 11:26:48AM +0100, Stephan Mueller wrote: > > Could you please help me understand where that check should be and what > > should be done at the crypto API level? > > All I was asking for is a length chec

Re: [PATCH] crypto: AEAD: add check for presence of auth tag

2015-01-05 Thread Stephan Mueller
Am Montag, 5. Januar 2015, 21:19:01 schrieb Herbert Xu: Hi Herbert, > On Tue, Dec 30, 2014 at 10:16:03PM +0100, Stephan Mueller wrote: > > The AEAD decryption operation requires the authentication tag to be > > present as part of the cipher text buffer. The added check verifies that > > the calle

Re: [PATCH] crypto: AEAD: add check for presence of auth tag

2015-01-05 Thread Herbert Xu
On Mon, Jan 05, 2015 at 11:26:48AM +0100, Stephan Mueller wrote: > > Could you please help me understand where that check should be and what > should > be done at the crypto API level? All I was asking for is a length check like the one at the top of crypto_authenc_decypt. Cheers, -- Email: He

Re: [PATCH] crypto: AEAD: add check for presence of auth tag

2015-01-05 Thread Herbert Xu
On Tue, Dec 30, 2014 at 10:16:03PM +0100, Stephan Mueller wrote: > The AEAD decryption operation requires the authentication tag to be > present as part of the cipher text buffer. The added check verifies that > the caller provides a cipher text buffer with at least the > authentication tag. > > A

[PATCH] crypto: AEAD: add check for presence of auth tag

2014-12-30 Thread Stephan Mueller
The AEAD decryption operation requires the authentication tag to be present as part of the cipher text buffer. The added check verifies that the caller provides a cipher text buffer with at least the authentication tag. As the cipher text is provided as a scatterlist, loop through the scatterlist