Re: [PATCH] arm64/crypto: remove redundant update of data

2014-08-25 Thread Ard Biesheuvel
On 24 August 2014 22:38, Colin King wrote: > From: Colin Ian King > > Originally found by cppcheck: > > [arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of > function parameter has no effect outside the function. Did you > forget dereferencing it? > > Updating data by blocks * SHA

[PATCH] arm64/crypto: remove redundant update of data

2014-08-24 Thread Colin King
From: Colin Ian King Originally found by cppcheck: [arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? Updating data by blocks * SHA256_BLOCK_SIZE at the end of ha2_finup is redundant code an