Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:48 Mon 16 Mar , Sami Tolvanen wrote: > Add Andy Polyakov's NEON optimized SHA-256 implementation. > > On Nexus 6, this implementation is ~2x faster than sha256-generic. do you plan to add the sha512 from openssl too? Whould be nice so armv4 can get faster implementatio too Best Regard

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-17 Thread Ard Biesheuvel
On 17 March 2015 at 16:09, Andy Polyakov wrote: > Hi, > Have you tested this code with the tcrypt.ko module? >>> >>> I have not, but I can look into it. >>> Did you talk to Andy about the license? I don't think this is permissible for the kernel as-is. >>> >>> Unless I have misunder

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-17 Thread Andy Polyakov
Hi, >>> Have you tested this code with the tcrypt.ko module? >> >> I have not, but I can look into it. >> >>> Did you talk to Andy about the license? I don't think this is >>> permissible for the kernel as-is. >> >> Unless I have misunderstood something, the license at the Cryptogams >> website in

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-17 Thread Sami Tolvanen
On Tue, Mar 17, 2015 at 04:09:40PM +0100, Andy Polyakov wrote: > I have no problems with reusing assembly modules in kernel context. Awesome, thank you for clarifying this. > I'd prefer if it can be arranged in way similar to bsaes-armv7 module, > i.e. we work together on shared copy of module th

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-16 Thread Ard Biesheuvel
On 16 March 2015 at 17:23, Sami Tolvanen wrote: > On Mon, Mar 16, 2015 at 05:08:03PM +0100, Ard Biesheuvel wrote: >> Have you tested this code with the tcrypt.ko module? > > I have not, but I can look into it. > >> Did you talk to Andy about the license? I don't think this is >> permissible for th

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-16 Thread Sami Tolvanen
On Mon, Mar 16, 2015 at 05:08:03PM +0100, Ard Biesheuvel wrote: > Have you tested this code with the tcrypt.ko module? I have not, but I can look into it. > Did you talk to Andy about the license? I don't think this is > permissible for the kernel as-is. Unless I have misunderstood something, th

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-16 Thread Ard Biesheuvel
Hello Sami, On 16 March 2015 at 16:48, Sami Tolvanen wrote: > Add Andy Polyakov's NEON optimized SHA-256 implementation. > > On Nexus 6, this implementation is ~2x faster than sha256-generic. > > Signed-off-by: Sami Tolvanen > Have you tested this code with the tcrypt.ko module? Some more comm

[PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-16 Thread Sami Tolvanen
Add Andy Polyakov's NEON optimized SHA-256 implementation. On Nexus 6, this implementation is ~2x faster than sha256-generic. Signed-off-by: Sami Tolvanen --- arch/arm/crypto/Makefile|2 arch/arm/crypto/sha256-armv7-neon.S | 819 arch/arm/