Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-06-01 Thread Herbert Xu
Alan Cox wrote: > > Zeroing long term keys makes sense but for the short lifepsan keys used on > the wire its a bit pointless irrespective of speed (I suspect done > properly the performance impact would be close to nil anyway) Sure, though we're not actually arguing whether keys should be zeroed

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-06-01 Thread Alan Cox
On Mon, 1 Jun 2009 14:48:37 +1000 Herbert Xu wrote: > On Sun, May 31, 2009 at 09:46:23PM -0700, David Miller wrote: > > > > I don't even want to think about what this does to IPSEC rule creation > > rates, that that matters heavily for cell phone networks where > > hundreds of thousands of nodes

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-05-31 Thread Herbert Xu
On Sun, May 31, 2009 at 09:46:23PM -0700, David Miller wrote: > > I don't even want to think about what this does to IPSEC rule creation > rates, that that matters heavily for cell phone networks where > hundreds of thousands of nodes come in and out of the server and each > such entry requires cr

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-05-31 Thread David Miller
From: Rik van Riel Date: Sun, 31 May 2009 10:38:52 -0400 > David Miller wrote: >> From: "Larry H." >> Date: Sat, 30 May 2009 19:57:20 -0700 >> >>> [PATCH] Use kzfree in crypto API context initialization and key/iv >>> handling >> Thanks f

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-05-31 Thread Rik van Riel
David Miller wrote: From: "Larry H." Date: Sat, 30 May 2009 19:57:20 -0700 [PATCH] Use kzfree in crypto API context initialization and key/iv handling Thanks for not CC:ing the crypto list, and also not CC:'ing the crypto maintainer. Your submissions leave a lot to be de

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-05-30 Thread David Miller
From: "Larry H." Date: Sat, 30 May 2009 19:57:20 -0700 > [PATCH] Use kzfree in crypto API context initialization and key/iv handling Thanks for not CC:ing the crypto list, and also not CC:'ing the crypto maintainer. Your submissions leave a lot to be desired, on every le