Re: [PATCH] PKCS#7: pkcs7_validate_trust(): initialize the _trusted output argument

2016-03-23 Thread Nicolai Stange
Herbert Xu writes: > On Sun, Mar 20, 2016 at 11:23:46PM +0100, Nicolai Stange wrote: >> Despite what the DocBook comment to pkcs7_validate_trust() says, the >> *_trusted argument is never set to false. >> >> pkcs7_validate_trust() only positively sets *_trusted upon encountering >> a trusted PKC

Re: [PATCH] PKCS#7: pkcs7_validate_trust(): initialize the _trusted output argument

2016-03-23 Thread Herbert Xu
On Sun, Mar 20, 2016 at 11:23:46PM +0100, Nicolai Stange wrote: > Despite what the DocBook comment to pkcs7_validate_trust() says, the > *_trusted argument is never set to false. > > pkcs7_validate_trust() only positively sets *_trusted upon encountering > a trusted PKCS#7 SignedInfo block. > > T

[PATCH] PKCS#7: pkcs7_validate_trust(): initialize the _trusted output argument

2016-03-20 Thread Nicolai Stange
Despite what the DocBook comment to pkcs7_validate_trust() says, the *_trusted argument is never set to false. pkcs7_validate_trust() only positively sets *_trusted upon encountering a trusted PKCS#7 SignedInfo block. This is quite unfortunate since its callers, system_verify_data() for example,