Ok, I will remove the unused code for now.
Thanks
James
On Mon, 2008-12-08 at 18:35 -0600, Kim Phillips wrote:
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.htm
On Mon, 08 Dec 2008 13:55:07 -0800
James Hsiao <[EMAIL PROTECTED]> wrote:
> >> + /* figure how many gd is needed */
> >> + if (aad_len) {
> >> + num_gd = get_sg_count(assoc, aad_len) +
> >> + get_sg_count(src, datalen);
>
> > this is dead code - aad_len is
Hi Kim,
>> + /* figure how many gd is needed */
>> + if (aad_len) {
>> + num_gd = get_sg_count(assoc, aad_len) +
>> + get_sg_count(src, datalen);
> this is dead code - aad_len is never non-zero - is there some code
> missing from crypto4xx_alg.c? Also, II
On Fri, 5 Dec 2008 06:41:13 +0100
Stefan Roese <[EMAIL PROTECTED]> wrote:
> On Friday 05 December 2008, Kim Phillips wrote:
> > > diff --git a/arch/powerpc/boot/dts/canyonlands.dts
> > > b/arch/powerpc/boot/dts/canyonlands.dts index 79fe412..b0f0096 100644
> > > --- a/arch/powerpc/boot/dts/canyonl
On Fri, 05 Dec 2008 15:24:11 -0800
James Hsiao <[EMAIL PROTECTED]> wrote:
> Without the check, nbytes could become negative. The aead test case
> with .np will crash(ie. gcm tests), those test have sg->length >
> nbytes.
>
> About aad_len, we didn't release code that use aad yet. We did test thi
Hi Kim,
I try to address some of the comments. I am not mentioning things that I
agree with you.
> + */
> +static int get_sg_count(struct scatterlist *sg_list, int nbytes)
> +{
> + struct scatterlist *sg = sg_list;
> + int sg_nents = 0;
> +
> + while (nbytes) {
> + sg_ne
On Friday 05 December 2008, Kim Phillips wrote:
> > diff --git a/arch/powerpc/boot/dts/canyonlands.dts
> > b/arch/powerpc/boot/dts/canyonlands.dts index 79fe412..b0f0096 100644
> > --- a/arch/powerpc/boot/dts/canyonlands.dts
> > +++ b/arch/powerpc/boot/dts/canyonlands.dts
> > @@ -116,6 +116,13 @@
>
On Tue, 02 Dec 2008 14:17:12 -0800
James Hsiao <[EMAIL PROTECTED]> wrote:
> Hi,
>
> This patch add canyonlands support.
>
> Few performance optimizations:
> Redesigned the crypto4xx_build_pd(), which now calculate number of
> scatter and gather descriptors need before taking them. Instead take
